Fix use of SSLContext with sniffing #199
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's not triggered for normal code.
miguelgrinberg
approved these changes
Jan 6, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Jan 6, 2025
* Fix use of SSLContext with sniffing * Fix lint * Ignore enabled_cleanup_closed warning It's not triggered for normal code. * Remove warning filter (cherry picked from commit af34992)
github-actions bot
pushed a commit
that referenced
this pull request
Jan 6, 2025
* Fix use of SSLContext with sniffing * Fix lint * Ignore enabled_cleanup_closed warning It's not triggered for normal code. * Remove warning filter (cherry picked from commit af34992)
This was referenced Jan 6, 2025
pquentin
pushed a commit
that referenced
this pull request
Jan 6, 2025
pquentin
pushed a commit
that referenced
this pull request
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes elastic/elasticsearch-py#2731
When sniffing is enabled,
warn_if_varying_node_config_optionschecks if all node configs use the same options besides host, port, and a few others. This is done usingdataclasses.asdict, which will try to use the same mechanism as pickling to convertSSLContextobjects to a dictionary. However,SSLContextobjects cannot be pickled, and there's no good way to check that they are identical.Instead, we choose to ignore
ssl_context. We also have to stop usingasdict()because it converts all keys, even those we don't need. Instead, we use the shallow copy workaround from the docs: https://docs.python.org/3/library/dataclasses.html#dataclasses.asdict.