-
Notifications
You must be signed in to change notification settings - Fork 16
Fix aiohttp call type: ignore differently #190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 3, 2024
miguelgrinberg
approved these changes
Oct 3, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Oct 3, 2024
(cherry picked from commit d50788d)
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.17 8.17
# Navigate to the new working tree
cd .worktrees/backport-8.17
# Create a new branch
git switch --create backport-190-to-8.17
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 d50788d6afb278739dc11a6842fae8602a8ea791
# Push it to GitHub
git push --set-upstream origin backport-190-to-8.17
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.17 Then, create a pull request where the |
github-actions bot
pushed a commit
that referenced
this pull request
Jan 6, 2025
(cherry picked from commit d50788d)
pquentin
added a commit
that referenced
this pull request
Jan 6, 2025
(cherry picked from commit d50788d) Co-authored-by: Quentin Pradet <[email protected]>
pquentin
added a commit
to pquentin/elastic-transport-python
that referenced
this pull request
Jan 6, 2025
(cherry picked from commit d50788d)
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
pquentin
added a commit
that referenced
this pull request
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested by @miguelgrinberg (thanks!), this is likely the simplest way to properly fix that for now. This will also fix CI which is currently complaining there is no problem due to the
MutableMapping[str, Any]
type.The CI error is fixed in #191.