Skip to content

Conversation

pquentin
Copy link
Member

@pquentin pquentin commented Oct 3, 2024

As suggested by @miguelgrinberg (thanks!), this is likely the simplest way to properly fix that for now. This will also fix CI which is currently complaining there is no problem due to the MutableMapping[str, Any] type.

The CI error is fixed in #191.

@pquentin pquentin merged commit d50788d into elastic:main Oct 3, 2024
4 of 11 checks passed
@pquentin pquentin deleted the fix-aiohttp-type-ignore branch October 3, 2024 12:58
github-actions bot pushed a commit that referenced this pull request Oct 3, 2024
Copy link

github-actions bot commented Jan 6, 2025

The backport to 8.17 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.17 8.17
# Navigate to the new working tree
cd .worktrees/backport-8.17
# Create a new branch
git switch --create backport-190-to-8.17
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 d50788d6afb278739dc11a6842fae8602a8ea791
# Push it to GitHub
git push --set-upstream origin backport-190-to-8.17
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.17

Then, create a pull request where the base branch is 8.17 and the compare/head branch is backport-190-to-8.17.

github-actions bot pushed a commit that referenced this pull request Jan 6, 2025
pquentin added a commit that referenced this pull request Jan 6, 2025
(cherry picked from commit d50788d)

Co-authored-by: Quentin Pradet <[email protected]>
pquentin added a commit to pquentin/elastic-transport-python that referenced this pull request Jan 6, 2025
@pquentin
Copy link
Member Author

pquentin commented Jan 6, 2025

💚 All backports created successfully

Status Branch Result
8.17

Questions ?

Please refer to the Backport tool documentation

pquentin added a commit that referenced this pull request Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants