Fix basic auth built from percent-encoded URLs #143
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
technige
reviewed
Jan 15, 2024
elastic_transport/client_utils.py
Outdated
| # percent-encoded but does not percent-decode userinfo, so we have to | ||
| # do it ourselves to build the basic auth header correctly. | ||
| auth = urllib.parse.unquote(parsed_url.auth) | ||
| username, _, password = auth.partition(":") |
There was a problem hiding this comment.
Would it not be (slightly) better to partition first, and then unquote? In the (extreme) case that the username contains an encoded colon (I can't imagine why, but it could) then this would partition in the wrong place. The actual separator we're looking for should never be encoded by definition, though.
There was a problem hiding this comment.
Thanks, fixed in 23f9946. (I meant "colon in userinfo username, not is.)
technige
approved these changes
Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #141
Tested succesfully with
Elasticsearch("https://test@:@test@@host").