-
Notifications
You must be signed in to change notification settings - Fork 16
HTTPX async node #137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HTTPX async node #137
Conversation
💚 CLA has been signed |
@b4sus Wow, this is exciting! Thanks for working on this. I'd like to set the expectations here by noting that this is a large change that will require multiple rounds of review, and that I will be slow because of the holidays season coming up. My goal is to have this merged by the end of January. I haven't looked at the code in any meaningful way but I noticed it uses Also, can you please sign the CLA? Thanks again! |
…ted in favor of builtin TimeError
The The other option is to stick to |
Are you OK if I submit some small changes to this branch myself? |
Of course, go for it. |
All nodes are named the same way.
They are arguably worse, but make comparisons easier. Switching to better names should be done in a separate change for all nodes.
A previous comment used `exc` by mistake.
Could not help myself, this is turning into bigger changes. Hope that's still OK 🙈 |
It is important to use ssl_context_from_node_config to read configuration like `ssl_version`.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! This looks good to me now. I'm happy to merge if you are. 🎉
Follow up of the issue #95.
Please, pay attention to the verify/cert configuration, this is something I am not very familiar with nor could I test it.
Things to check: