Elastic stack: use elasticsearch.yml config #554
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
mtojek
commented
Oct 26, 2021
Comment on lines
11
to
15
| script.max_compilations_rate: "use-context" | ||
| script.context.template.max_compilations_rate: "unlimited" | ||
| script.context.ingest.cache_max_size: 2000 | ||
| script.context.processor_conditional.cache_max_size: 2000 | ||
| script.context.template.cache_max_size: 2000 |
There was a problem hiding this comment.
@P1llus I'm working on forking the Elasticsearch config for 8.x. Do you know how these script.* settings should look like?
There was a problem hiding this comment.
@mtojek they can all be removed actually, they should not be needed anymore. We should monitor for any flakiness, but except that it is actually better to run on the newer better default settings
|
/test |
jsoriano
approved these changes
Oct 27, 2021
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #552
This PR introduces a dedicated YML config for Elasticsearch. With this change we'll be able to introduce breaking config changes and not harm end-users.