Make is_ready container-image configurable #2593
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test |
jsoriano
previously approved these changes
Jun 13, 2025
jsoriano
reviewed
Jun 13, 2025
| @@ -110,6 +112,7 @@ type ImageRefs struct { | |||
| Elasticsearch string `yaml:"elasticsearch"` | |||
| Kibana string `yaml:"kibana"` | |||
| Logstash string `yaml:"logstash"` | |||
| is_ready string `yaml:"is_ready"` | |||
There was a problem hiding this comment.
Suggested change
| is_ready string `yaml:"is_ready"` | |
| IsReady string `yaml:"is_ready"` |
There was a problem hiding this comment.
Please review other compose files in this directory that may be using this image.
mrodm
reviewed
Jun 13, 2025
| @@ -28,7 +28,7 @@ services: | |||
| - "127.0.0.1:9200:9200" | |||
|
|
|||
| elasticsearch_is_ready: | |||
| image: tianon/true:multiarch | |||
| image: "${IS_READY_IMAGE_REF}" | |||
There was a problem hiding this comment.
Should it be updated also the docker-compose for local services ?
https://github.com/elastic/elastic-package/blob/f00e430124b1e8bb43f234fcc7e756461a107786/internal/stack/_static/local-services-docker-compose.yml.tmpl
To use that environment variable, this file uses facts instead. Here it is the method where those facts are set:
| @@ -37,6 +37,7 @@ const ( | |||
| elasticsearchImageName = "docker.elastic.co/elasticsearch/elasticsearch" | |||
| kibanaImageName = "docker.elastic.co/kibana/kibana" | |||
| logstashImageName = "docker.elastic.co/logstash/logstash" | |||
| isreadyImageName = "tianon/true:multiarch" | |||
There was a problem hiding this comment.
Nit.
Suggested change
| isreadyImageName = "tianon/true:multiarch" | |
| isReadyImageName = "tianon/true:multiarch" |
💔 Build Failed
Failed CI StepsHistory |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi everybody,
due to the reduced Docker rate limits, it may happen that the stack can no longer be downloaded because of the is_ready Docker image.
Therefore, I have created an additional environment variable that allows overriding the image.
Best regards
Max