Skip to content

[8.18] (backport #7754) Set fullnameOverride and validate Otel kube-stack deployment datastreams are being written (metrics, traces) #8001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 29, 2025

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Apr 28, 2025

What does this PR do?

Adds tests to ensure the Helm chart is correctly deployed and data pushed to Elasticsearch:

  • Validates metrics collected with the kubeletstats receiver are written to Elasticsearch.
  • Deploys a Java application to validate auto-instrumentation works properly and the corresponding traces documents are available in Elasticsearch. As an alternative, I tried to install the OpenTelemetry demo Helm Chart and assert its traces, but it is too heavy (big images, e.g. flagd → 1.2GB) for the testing timeouts.

Why is it important?

Fixes #7381


This is an automatic backport of pull request #7754 done by Mergify.

…ams are being written (metrics, traces) (#7754)

(cherry picked from commit 8ec0229)

# Conflicts:
#	testing/integration/otel_helm_test.go
@mergify mergify bot requested review from a team as code owners April 28, 2025 10:20
@mergify mergify bot added backport conflicts There is a conflict in the backported pull request labels Apr 28, 2025
@mergify mergify bot requested review from ycombinator and pchila and removed request for a team April 28, 2025 10:20
Copy link
Contributor Author

mergify bot commented Apr 28, 2025

Cherry-pick of 8ec0229 has failed:

On branch mergify/bp/8.18/pr-7754
Your branch is up to date with 'origin/8.18'.

You are currently cherry-picking commit 8ec022980.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	new file:   changelog/fragments/1744384247-set-collector's-fullnameOverride-for-edot-kube-stack-values.yaml
	modified:   deploy/helm/edot-collector/kube-stack/managed_otlp/values.yaml
	modified:   deploy/helm/edot-collector/kube-stack/values.yaml
	modified:   testing/integration/kubernetes_agent_standalone_test.go
	new file:   testing/integration/testdata/java_app.yaml

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   testing/integration/otel_helm_test.go

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

@elasticmachine
Copy link
Collaborator

elasticmachine commented Apr 28, 2025

Copy link

@rogercoll rogercoll merged commit c50d318 into 8.18 Apr 29, 2025
11 checks passed
@rogercoll rogercoll deleted the mergify/bp/8.18/pr-7754 branch April 29, 2025 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport conflicts There is a conflict in the backported pull request skip-changelog Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants