Remove most legacy generated files. #399
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
March 22, 2019 14:16
Initial rename changelog is now irrelevant. Since 1.0.0 it disappeared, that's the story
Both legacy files have a better replacement now. To people's eyes it will just have moved directory. Implementation details are irrelevant.
ruflin
approved these changes
Mar 25, 2019
webmat
added a commit
to webmat/ecs
that referenced
this pull request
Mar 25, 2019
* Remove legacy Beats fields.yml file * Remove legacy schema.csv file
webmat
added a commit
that referenced
this pull request
Mar 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes
Both files now have official replacements that are more complete.
The one file left in generated/legacy/ is the ES template based on the libbeat
generator. I've generated two sample templates in Python in order for things
to move forward rapidly. Not sure if we should go back to libbeat's. Needs more
discussion when we'll have time.
I'd like to merge this on Monday at the latest, if possible.
cc @ruflin