Ensure we can handle more data types in ElapsedMillisecond/Elapsed from serilog #514
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
reakaleek
approved these changes
Jun 27, 2025
| } | ||
| catch | ||
| { | ||
| // ignored |
Member
There was a problem hiding this comment.
Q: Would it make sense to put a warning here? I feel like returning null could have unexpected behaviour for the user? Asking this without knowing all the context.
Member
Author
There was a problem hiding this comment.
Normally yeah, but since this is after we exhausted all the regular casts its best effort from here on out.
reakaleek
approved these changes
Jun 27, 2025
flobernd
approved these changes
Jun 27, 2025
JeremyBessonElastic
approved these changes
Jun 27, 2025
Collaborator
JeremyBessonElastic
left a comment
JeremyBessonElastic
left a comment
There was a problem hiding this comment.
LGTM
Minor comment: the logic with all the ?/if all imbricated might deserve a simpler form with only if and a private method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.