-
Notifications
You must be signed in to change notification settings - Fork 113
Network sec: rebrand and new cloud UX, IP filters in serverless #1785
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing improvements here!! I love the new structure!
I have added some comments for your review, feel free to ignore any of them.
In general the majority of my comments are about:
-
You have used multiple times
by default all your deployments are accessible over the internet
to mean thatall access is allowed
, oris accessible without restrictions
. The first statement is in my opinion not accurate or doesn't add any value (this is explained more in other comments). -
When dealing with
IP filters
the termsIP filters
,traffic filters
and even the usage of the wordrules
feel a bit randomly used, and could be misleading.
Most probably I'm missing background in some of my comments, so feel free to correct me!
Co-authored-by: Edu González de la Herrán <[email protected]>
Co-authored-by: Edu González de la Herrán <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for the updates, the content feels smoother and clearer now!
I've shared some concerns about the API doc, as I got completely stucked understanding it.
Hoping it will help!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!! Thanks for all the work put into this :elasticheart:
This PR updates the core pages related to traffic filtering to reflect the new ux (issue: https://github.com/elastic/platform-docs-team/issues/682)
This is PR 1 of
2 or 3many. The first PR will capture the core changes needed to ship the feature. Subsequent PRs will update references to traffic filters other places in the docs, do any necessary API reference cleanup, etc.Followup PRs to merge right after:
any order after:
independent (ship anytime after the feature is released):
Summary
This PR is pretty big, so you can use the links below to review it
Key changes
Network security and network security policies
Pulled policy/rule logic out of this page and into dedicated pages for Elastic Cloud and ECE
IP filters
Rebranded as "IP filter network security policies"
Updated all flows impacted by UX changes
snippet: wayfinding to network security page
Private connections
repositioned them as a connectivity strategy with VCPE filtering optional for everything but Azure
used deployment aliases to test/connect privatelink for consistency
snippets: wayfinding to network security page, associate filter, private url structure, find endpoint, fleet
used deployment aliases to test/connect privatelink for consistency
snippets: wayfinding to network security page, associate filter, private url structure, find endpoint, fleet
used deployment aliases to test/connect privatelink for consistency
snippets: wayfinding to network security page, associate filter, private url structure, find endpoint, fleet
Remote clusters
Access deployments of another Elastic Cloud organization
deploy-manage/remote-clusters/ec-remote-cluster-other-ess.md
Secondary changes
todo: serverless reference doc URL
Updated references to traffic filters to "network security" or "IP filtering and private connections" as needed, added IP filtering to the list of security features for serverless
deploy-manage/_snippets/ecloud-security.md
snippets: security in elastic cloud, features for cluster communication and network security, feature comparison
snippets: features for cluster communication and network security, feature comparison
Open questions
Is the umbrella term for private connection filters "VCPE filtering" (e.g. "add a private connection, then filter traffic to your deployment using VCPE filters")? Will this term be used for GCP?ANSWER: It's "VPC filtering"
For Azure, is associating a private connection policy with a deployment required, or optional?ANSWER: technically optional but strongly recommended
For Azure inter-region private links, what region should the associated policy be created in?
ANSWER: same region as the deployment
SR TODO
[ ] more visibility to azure inter-region private links