Skip to content

Use new versions.yml config to render applies_to tags #1465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

reakaleek
Copy link
Member

@reakaleek reakaleek commented Jun 27, 2025

Changes

  • Introduce a new Versions Config.
  • Use versions.yml config for applies_to tags.

Notes

We were not able to use assembler config because the config needs to be available in isolated builds as well.

Preview

https://docs-v3-preview.elastic.dev/elastic/docs-builder/pull/1465/syntax/applies#inline-examples

image

@reakaleek reakaleek requested review from a team as code owners June 27, 2025 15:46
@reakaleek reakaleek marked this pull request as draft June 27, 2025 15:51
@reakaleek reakaleek requested a review from Copilot June 29, 2025 20:14
@reakaleek reakaleek self-assigned this Jun 29, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enables versioning support for “applies_to” by incorporating a new VersionsConfiguration into the build context and updating lifecycle values across tests, directives, and UI components. Key changes include replacing “discontinued” with “removed” in applicable scenarios, adding several new tests to verify parsing behavior, and updating CLI, assembler, and rendering components to utilize version configuration support.

Reviewed Changes

Copilot reviewed 42 out of 42 changed files in this pull request and generated 2 comments.

File Description
tests/authoring/Framework/Setup.fs Adds versioning systems to BuildContext; note potential incorrect ID for “eck”.
src/Elastic.Markdown/Myst/Roles/RoleParser.cs Fixes content slice calculation to avoid overrunning the span.
Other files Various updates to tests, CLI commands, components, and documentation reflecting lifecycle value changes and new versioning support.

@reakaleek reakaleek changed the title WIP: Applies_to versioning Use new versions.yml config to render applies_to tags Jun 29, 2025
@reakaleek reakaleek marked this pull request as ready for review June 29, 2025 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant