-
Notifications
You must be signed in to change notification settings - Fork 21
Use new versions.yml
config to render applies_to
tags
#1465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR enables versioning support for “applies_to” by incorporating a new VersionsConfiguration into the build context and updating lifecycle values across tests, directives, and UI components. Key changes include replacing “discontinued” with “removed” in applicable scenarios, adding several new tests to verify parsing behavior, and updating CLI, assembler, and rendering components to utilize version configuration support.
Reviewed Changes
Copilot reviewed 42 out of 42 changed files in this pull request and generated 2 comments.
File | Description |
---|---|
tests/authoring/Framework/Setup.fs | Adds versioning systems to BuildContext; note potential incorrect ID for “eck”. |
src/Elastic.Markdown/Myst/Roles/RoleParser.cs | Fixes content slice calculation to avoid overrunning the span. |
Other files | Various updates to tests, CLI commands, components, and documentation reflecting lifecycle value changes and new versioning support. |
c3d429a
to
464869d
Compare
versions.yml
config to render applies_to
tags
Changes
versions.yml
config forapplies_to
tags.Notes
We were not able to use assembler config because the config needs to be available in isolated builds as well.
Preview
https://docs-v3-preview.elastic.dev/elastic/docs-builder/pull/1465/syntax/applies#inline-examples