Skip to content
This repository was archived by the owner on Aug 4, 2023. It is now read-only.

Add type information for typescript #187

Conversation

nicolaichuk
Copy link

@trentm Please review and merge to upstream.

@cla-checker-service
Copy link

❌ Author of the following commits did not sign a Contributor Agreement:
a32bc06

Please, read and sign the above mentioned agreement if you want to contribute to this project

@github-actions github-actions bot added the agent-nodejs Make available for APM Agents project planning. label Nov 3, 2022
@apmmachine
Copy link

❕ Build Aborted

The PR is not allowed to run in the CI yet

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Start Time: 2022-11-03T19:43:14.428+0000

  • Duration: 3 min 28 sec

Steps errors 2

Expand to view the steps failures

Load a resource file from a library
  • Took 0 min 0 sec . View more details here
  • Description: approval-list/elastic/apm-nodejs-http-client.yml
Error signal
  • Took 0 min 0 sec . View more details here
  • Description: githubApiCall: The REST API call https://api.github.com/orgs/elastic/members/nicolaichuk return the message : java.lang.Exception: httpRequest: Failure connecting to the service https://api.github.com/orgs/elastic/members/nicolaichuk : httpRequest: Failure connecting to the service https://api.github.com/orgs/elastic/members/nicolaichuk : Code: 404Error: {"message":"User does not exist or is not a member of the organization","documentation_url":"https://docs.github.com/rest/reference/orgs#check-organization-membership-for-a-user"}

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@trentm
Copy link
Member

trentm commented Aug 3, 2023

@nicolaichuk Thanks for the PR, and my apologies for the long time in replying. I don't want to take a large .d.ts file for this package because:

We would possibly consider exporting times for the http-client in that repo, but the same maintenance issue with such a well-defined, large .d.ts file would still apply.

@trentm trentm closed this Aug 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
agent-nodejs Make available for APM Agents project planning.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants