Skip to content

fix: add "s3/" prefix to destination.service.resource for S3 spans #3102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 17, 2023

Conversation

trentm
Copy link
Member

@trentm trentm commented Jan 17, 2023

Closes: #3084
Refs: elastic/apm#738

@trentm trentm self-assigned this Jan 17, 2023
@github-actions github-actions bot added the agent-nodejs Make available for APM Agents project planning. label Jan 17, 2023
@apmmachine
Copy link
Contributor

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-01-17T18:00:28.121+0000

  • Duration: 26 min 2 sec

Test stats 🧪

Test Results
Failed 0
Passed 322162
Skipped 0
Total 322162

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run module tests for <modules> : Run TAV tests for one or more modules, where <modules> can be either a comma separated list of modules (e.g. memcached,redis) or the string literal ALL to test all modules

  • run benchmark tests : Run the benchmark test only.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@trentm trentm merged commit e694757 into main Jan 17, 2023
@trentm trentm deleted the trentm/fix-dest-resource-s3-prefix branch January 17, 2023 18:27
PeterEinberger pushed a commit to fpm-git/apm-agent-nodejs that referenced this pull request Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agent-nodejs Make available for APM Agents project planning.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[META 739] Add "s3/"-prefix to S3 destination.service.resource
2 participants