fix: improve require es module #61
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@popomore, thanks for your PR! By analyzing the history of the files in this pull request, we identified @gxcsoccer, @dead-horse and @ngot to be potential reviewers. |
Compile such as babel, typescript will compile es module always containing `__esModule`, we should do right things. Typescript 2.2 fix this bug in microsoft/TypeScript#13871
popomore
force-pushed
the
fix-require-es-module
branch
from
d87c7d3 to
be063b2
Compare
Codecov Report
@@ Coverage Diff @@
## master #61 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 17 17
Lines 797 792 -5
=====================================
- Hits 797 792 -5
Continue to review full report at Codecov.
|
dead-horse
approved these changes
Feb 23, 2017
fengmk2
approved these changes
Feb 23, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm testpassesAffected core subsystem(s)
Description of change
Compile such as babel, typescript will compile es module always
containing
__esModule, we should do right things.Typescript 2.2 fix this bug in
microsoft/TypeScript#13871