Test adjacent nested braces#44
Merged
xuhdev merged 1 commit intoeditorconfig:masterfrom Nov 29, 2020
Merged
Conversation
Nested braces should work correctly when they are adjacent at the start, end, or both. However, this was not handled correctly in editorconfig-core-py. Add tests to cover. I have confirmed that these tests all pass for editorconfig-core-c and 1, 3, 4, and 5 fail for editorconfig-core-py without editorconfig/editorconfig-core-py#33 and pass once applied. Signed-off-by: Kevin Locke <kevin@kevinlocke.name>
xuhdev
approved these changes
Nov 29, 2020
Member
xuhdev
left a comment
xuhdev
left a comment
There was a problem hiding this comment.
LGTM. This seems like an oversight when creating nested tests.
Member
|
Thanks! |
Contributor
Author
|
My pleasure. Thanks for reviewing and merging it so quickly @xuhdev! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nested braces should work correctly when they are adjacent at the start, end, or both. However, this was not handled correctly in editorconfig-core-py. This PR adds tests to cover this case.
I have confirmed that these tests all pass for editorconfig-core-c while 1, 3, 4, and 5 fail for editorconfig-core-py without editorconfig/editorconfig-core-py#33 and pass once applied.
Thanks for considering,
Kevin