Skip to content

Conversation

ejlee3
Copy link
Member

@ejlee3 ejlee3 commented Nov 8, 2023

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/device-rest-go/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?)
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?)

Testing Instructions

New Dependency Instructions (If applicable)

Signed-off-by: Elizabeth J Lee <[email protected]>
@ejlee3 ejlee3 requested a review from bill-mahoney November 8, 2023 18:51
@codecov-commenter
Copy link

Codecov Report

Merging #364 (41c1ef5) into main (549007a) will not change coverage.
The diff coverage is n/a.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@           Coverage Diff           @@
##             main     #364   +/-   ##
=======================================
  Coverage   32.86%   32.86%           
=======================================
  Files           2        2           
  Lines         353      353           
=======================================
  Hits          116      116           
  Misses        224      224           
  Partials       13       13           

Copy link
Member

@cloudxxx8 cloudxxx8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cloudxxx8 cloudxxx8 merged commit 63560b1 into edgexfoundry:main Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants