Skip to content

Conversation

lenny-goodell
Copy link
Member

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/device-rest-go/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?) N/A
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?)

Testing Instructions

make test
make build
make docker
Verify all are successful

New Dependency Instructions (If applicable)

@lenny-goodell lenny-goodell added the ci issue_type denoting non-code changes such as testing or compilation label Sep 12, 2023
@lenny-goodell lenny-goodell added this to the Napa milestone Sep 12, 2023
@lenny-goodell lenny-goodell merged commit 7661139 into edgexfoundry:main Sep 12, 2023
@lenny-goodell lenny-goodell deleted the go-1.21 branch September 12, 2023 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci issue_type denoting non-code changes such as testing or compilation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants