fix: Range check for float64/32 equal to 0.0 #330
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IkerDC
force-pushed
the
EF-329
branch
2 times, most recently
from
22341a1 to
37fb718
Compare
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #330 +/- ##
=======================================
Coverage 31.95% 31.95%
=======================================
Files 2 2
Lines 363 363
=======================================
Hits 116 116
Misses 234 234
Partials 13 13
|
- Removed bug of missing 0.0 check in old imlpementation. - Adapted check range procedure to the same as in Int/Uint. Signed-off-by: idiaz <[email protected]> fix: Add test case for floats equal 0.0 Signed-off-by: idiaz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/device-rest-go/blob/main/.github/Contributing.md
PR Checklist
Please check if your PR fulfills the following requirements:
BREAKING CHANGE:describing the break)Tested the functions as stand-alone, added unit test, tested with real devices returning a deviceResource of "0.0".
No docs related to this part.
Testing Instructions
New Dependency Instructions (If applicable)