Skip to content

Move sutrle_mod.F90 to common #296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 31, 2025
Merged

Move sutrle_mod.F90 to common #296

merged 1 commit into from
Jul 31, 2025

Conversation

samhatfield
Copy link
Collaborator

As far as I can see this subroutine doesn't contain any platform- or precision-specific code. The CPU and GPU versions are the same modulo whitespace, so we can move it to the common library and save some lines of code.

@samhatfield samhatfield requested a review from wdeconinck July 28, 2025 15:53
@samhatfield samhatfield added the tidying Tidying up code or removing unused features label Jul 29, 2025
Copy link
Collaborator

@wdeconinck wdeconinck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe you could also remove it from the gpu/internal subdirectory.
common should be common to gpu and cpu as well.

@samhatfield
Copy link
Collaborator Author

I believe you could also remove it from the gpu/internal subdirectory. common should be common to gpu and cpu as well.

I renamed it from gpu/internal/sutrle_mod.F90 to common/internal/sutrle_mod.F90 as I think that's the file with the whole history attached.

Copy link
Collaborator

@wdeconinck wdeconinck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Always good to avoid possibly diverging subroutines.

@wdeconinck wdeconinck merged commit 886d68d into develop Jul 31, 2025
32 checks passed
@samhatfield samhatfield deleted the move_sutrle_to_common branch July 31, 2025 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tidying Tidying up code or removing unused features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants