Skip to content

fix(material-renderers): add missing Mui-error class for some controls #2433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 8, 2025
Merged

fix(material-renderers): add missing Mui-error class for some controls #2433

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cc483eb
fix(material-renderers): add missing Mui-error class for some controls
vishnutsivan Apr 4, 2025
9f53777
reverted version change
vishnutsivan Apr 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/material-renderers/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@jsonforms/material-renderers",
"version": "3.5.1",
"version": "3.5.2",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert this. Version numbers are automatically increased when we release a new version via CI

Copy link
Contributor Author

@vishnutsivan vishnutsivan Apr 8, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reverted. when can we expect new version?

"description": "Material Renderer Set for JSON Forms",
"repository": "https://github.com/eclipsesource/jsonforms",
"bugs": "https://github.com/eclipsesource/jsonforms/issues",
Expand Down
2 changes: 2 additions & 0 deletions packages/material-renderers/src/mui-controls/MuiInputInteger.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ export const MuiInputInteger = React.memo(function MuiInputInteger(
id,
enabled,
uischema,
isValid,
path,
handleChange,
config,
Expand Down Expand Up @@ -70,6 +71,7 @@ export const MuiInputInteger = React.memo(function MuiInputInteger(
autoFocus={appliedUiSchemaOptions.focus}
inputProps={inputProps}
fullWidth={true}
error={!isValid}
/>
);
});
2 changes: 2 additions & 0 deletions packages/material-renderers/src/mui-controls/MuiInputNumber.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ export const MuiInputNumber = React.memo(function MuiInputNumber(
id,
enabled,
uischema,
isValid,
path,
handleChange,
config,
Expand Down Expand Up @@ -68,6 +69,7 @@ export const MuiInputNumber = React.memo(function MuiInputNumber(
autoFocus={appliedUiSchemaOptions.focus}
inputProps={inputProps}
fullWidth={true}
error={!isValid}
/>
);
});
2 changes: 2 additions & 0 deletions packages/material-renderers/src/mui-controls/MuiInputTime.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ export const MuiInputTime = React.memo(function MuiInputTime(
id,
enabled,
uischema,
isValid,
path,
handleChange,
config,
Expand All @@ -61,6 +62,7 @@ export const MuiInputTime = React.memo(function MuiInputTime(
disabled={!enabled}
autoFocus={appliedUiSchemaOptions.focus}
fullWidth={true}
error={!isValid}
/>
);
});
2 changes: 2 additions & 0 deletions packages/material-renderers/src/mui-controls/MuiSelect.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ export const MuiSelect = React.memo(function MuiSelect(
enabled,
schema,
uischema,
isValid,
path,
handleChange,
options,
Expand All @@ -69,6 +70,7 @@ export const MuiSelect = React.memo(function MuiSelect(
onChange={(ev) => handleChange(path, ev.target.value || undefined)}
fullWidth={true}
multiple={multiple || false}
error={!isValid}
>
{[
<MenuItem value={''} key='jsonforms.enum.none'>
Expand Down