-
Notifications
You must be signed in to change notification settings - Fork 409
WIP: Angular 15 and more #2130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Angular 15 and more #2130
Conversation
✅ Deploy Preview for jsonforms-examples ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
@sdirix Before I put in much more time, is this something you guys are interested in? My changes probably drop support for quite a few versions of the frameworks just like with angular where typescript >= 4.8.4 is required for angular 15, hence dropping support for 12, 13, and 14.0.0 |
Hi @JonasDev17! Thanks for your efforts! If this is properly finished then we would definitely merge and use it going forward. We try to stay up to date, so if Angular 12/13/14 are then out of the question then that's fine. Users of these Angular versions can then just use an older version of JSON Forms. My feeling is that this PR exploded a bit in scope. We would be perfectly fine just with the Angular update which is also easier to review than a huge PR touching rollup, typedoc, eslint, Material UI, even rimraf, etc. etc. My suggestion would be to dial this a bit back and focus on the Angular packages. I understand that a Typescript update is needed for them which seemed to motivate all the other changes too. If you polish the PR so that |
Thanks for the feedback. I removed the other packages and finally got it to build but the examples page is empty - not sure what the problem is here. |
I updated lots of packages which will require some testing. I updated angular to angular 14.2 & 15, dropping support for 12 & 13 & 14.0.0, Typescript to 4.8.4.
I couldn't get the Vue vanilla build to pass because I never used Vue.
I am not sure if what I did here is any good, so I am open to feedback!