Skip to content

Conversation

JonasDev17
Copy link

I updated lots of packages which will require some testing. I updated angular to angular 14.2 & 15, dropping support for 12 & 13 & 14.0.0, Typescript to 4.8.4.

I couldn't get the Vue vanilla build to pass because I never used Vue.

I am not sure if what I did here is any good, so I am open to feedback!

@CLAassistant
Copy link

CLAassistant commented Apr 12, 2023

CLA assistant check
All committers have signed the CLA.

@netlify
Copy link

netlify bot commented Apr 12, 2023

Deploy Preview for jsonforms-examples ready!

Name Link
🔨 Latest commit 0235eba
🔍 Latest deploy log https://app.netlify.com/sites/jsonforms-examples/deploys/643856ee962e250008c9d70f
😎 Deploy Preview https://deploy-preview-2130--jsonforms-examples.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@JonasDev17
Copy link
Author

JonasDev17 commented Apr 12, 2023

Not sure why these checks fail with a dependency issue as I have no dependency issues locally.

@JonasDev17 JonasDev17 changed the title Angular 15 and more WIP: Angular 15 and more Apr 13, 2023
@JonasDev17
Copy link
Author

@sdirix Before I put in much more time, is this something you guys are interested in? My changes probably drop support for quite a few versions of the frameworks just like with angular where typescript >= 4.8.4 is required for angular 15, hence dropping support for 12, 13, and 14.0.0
If you guys don't wanna update yet or drop support for older versions then there is no point in me putting in work for all these other framworks and for the dev environment with lerna and typedoc and all that and I'll just create an angular-only fork because to be honest, that's all I need for my project...

@sdirix
Copy link
Member

sdirix commented Apr 13, 2023

Hi @JonasDev17! Thanks for your efforts!

If this is properly finished then we would definitely merge and use it going forward. We try to stay up to date, so if Angular 12/13/14 are then out of the question then that's fine. Users of these Angular versions can then just use an older version of JSON Forms.

My feeling is that this PR exploded a bit in scope. We would be perfectly fine just with the Angular update which is also easier to review than a huge PR touching rollup, typedoc, eslint, Material UI, even rimraf, etc. etc.

My suggestion would be to dial this a bit back and focus on the Angular packages. I understand that a Typescript update is needed for them which seemed to motivate all the other changes too. If you polish the PR so that @jsonforms/core, @jsonforms/angular, @jsonforms/angular-material and @jsonforms/angular-test work (you can ignore the other packages for now by removing them from lerna), then we can have a look at the remaining open issues, i.e. updating the remaining packages and maybe typedoc.

@JonasDev17
Copy link
Author

@sdirix

Thanks for the feedback. I removed the other packages and finally got it to build but the examples page is empty - not sure what the problem is here.
I will probably have to create a new branch and open a new PR to clean up the PR.
But as far as I know, typedoc has to be updated as well because its part of every package and the lerna build process, no?

@JonasDev17 JonasDev17 closed this May 12, 2023
This was referenced Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants