Skip to content

fix visibility of error-icon in array #2037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 7, 2022
Merged

fix visibility of error-icon in array #2037

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/material/src/complex/TableToolbar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ import {
TableRow,
Tooltip
} from '@mui/material';
import { Grid, Hidden, Typography } from '@mui/material';
import { Grid, Typography } from '@mui/material';
import AddIcon from '@mui/icons-material/Add';
import ValidationIcon from './ValidationIcon';
import NoBorderTableCell from './NoBorderTableCell';
Expand Down Expand Up @@ -77,14 +77,14 @@ const TableToolbar = React.memo(
<Typography variant={'h6'}>{label}</Typography>
</Grid>
<Grid item>
<Hidden smUp={errors.length === 0}>
{errors.length !== 0 &&
<Grid item>
<ValidationIcon
id='tooltip-validation'
errorMessages={errors}
/>
</Grid>
</Hidden>
}
</Grid>
</Grid>
</NoBorderTableCell>
Expand Down
5 changes: 2 additions & 3 deletions packages/material/src/layouts/ArrayToolbar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import {
Grid,
IconButton,
Hidden,
Toolbar,
Tooltip,
Typography
Expand Down Expand Up @@ -30,11 +29,11 @@ export const ArrayLayoutToolbar = React.memo(
<Grid item>
<Typography variant={'h6'}>{label}</Typography>
</Grid>
<Hidden smUp={errors.length === 0}>
{errors.length !== 0 &&
<Grid item>
<ValidationIcon id='tooltip-validation' errorMessages={errors} />
</Grid>
</Hidden>
}
<Grid item>
<Grid container>
<Grid item>
Expand Down