Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/vanilla/src/cells/EnumCell.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ export const EnumCell = (props: EnumCellProps & VanillaRendererProps) => {
disabled={!enabled}
autoFocus={uischema.options && uischema.options.focus}
value={data || ''}
onChange={ev => handleChange(path, ev.target.value)}
onChange={ev => handleChange(path, ev.target.selectedIndex === 0 ? undefined : ev.target.value)}
>
{
[<option value='' key={'empty'} />]
Expand Down
21 changes: 21 additions & 0 deletions packages/vanilla/test/renderers/EnumCell.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -188,6 +188,27 @@ describe('Enum cell', () => {
expect(onChangeData.data.foo).toBe('b');
});

test('empty selection should lead to data deletion', () => {
const onChangeData: any = {
data: undefined
};
const core = initCore(fixture.schema, fixture.uischema, fixture.data);
wrapper = mount(
<JsonFormsStateProvider initState={{ core }}>
<TestEmitter
onChange={({ data }) => {
onChangeData.data = data;
}}
/>
<EnumCell schema={fixture.schema} uischema={fixture.uischema} path='foo' />
</JsonFormsStateProvider>
);
expect(onChangeData.data.foo).toBe('a');
const select = wrapper.find('select');
select.simulate('change', { target: { selectedIndex: 0 } });
expect(onChangeData.data.foo).toBe(undefined);
});

test('update via action', () => {
const data = { 'foo': 'b' };
const core = initCore(fixture.schema, fixture.uischema, data);
Expand Down