Skip to content

Preserve enum labels in React Material enum array #1904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 5, 2022
Merged

Preserve enum labels in React Material enum array #1904

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
416ac79
remove lodash startCase from label of checkboxes
JoshuaFortriede Mar 26, 2022
3074e33
Fix tests
TheZoker May 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions packages/material/src/complex/MaterialEnumArrayRenderer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ import {
FormHelperText,
Hidden
} from '@mui/material';
import startCase from 'lodash/startCase';
import isEmpty from 'lodash/isEmpty';
import React from 'react';

Expand Down Expand Up @@ -68,7 +67,7 @@ export const MaterialEnumArrayRenderer = ({
{...otherProps}
/>
}
label={startCase(option.label)}
label={option.label}
/>
);
})}
Expand Down
8 changes: 4 additions & 4 deletions packages/material/test/renderers/MaterialEnumArrayRenderer.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ describe('EnumArrayControl', () => {
);
const labels = wrapper.find('label');
expect(labels.first().text()).toBe('My Title');
expect(labels.last().text()).toBe('Bar');
expect(labels.last().text()).toBe('bar');
});

test('oneOf items - updates data', (done) => {
Expand Down Expand Up @@ -176,9 +176,9 @@ describe('EnumArrayControl', () => {
/>
);
const labels = wrapper.find('label');
expect(labels.at(0).text()).toBe('A');
expect(labels.at(1).text()).toBe('B');
expect(labels.at(2).text()).toBe('C');
expect(labels.at(0).text()).toBe('a');
expect(labels.at(1).text()).toBe('b');
expect(labels.at(2).text()).toBe('c');
});

test('enum items - updates data', (done) => {
Expand Down