[Angular] Fix path passing #1366
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
eneufeld
commented
May 10, 2019
eneufeld
commented
- remember path as propsPath
- use propsPath when passing
* remember path as propsPath * use propsPath when passing
|
@eneufeld Build is failing |
| @@ -32,11 +32,13 @@ import { | |||
| MatFormFieldModule, | |||
| MatInputModule | |||
| } from '@angular/material'; | |||
| import { BrowserDynamicTestingModule } from '@angular/platform-browser-dynamic/testing'; | |||
| import { MockNgRedux } from '@angular-redux/store/lib/testing'; | |||
There was a problem hiding this comment.
This should be imported from @angular-redux/store/testing
| entryComponents: [ | ||
| TextControlRenderer, | ||
| VerticalLayoutRenderer, | ||
| GroupLayoutRenderer |
There was a problem hiding this comment.
Can we have an assert condition that is explicit about the change? It seems rather funny to me that adding the GroupLayoutRenderer fixes the issue. Maybe we could check whether the renderered result contains a Group/Card component?
edgarmueller
approved these changes
May 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.