Skip to content

Conversation

edgarmueller
Copy link
Contributor

Introduce a new reducer for adding a substate that keeps track of any pre-defined data that can be queried by clients. Currently, the only such client is the AddItemDialog which reads the registry and merges any result with any default values found in the schema, if such.
Registration is happening via a given schema path and a JSON value. No validation of the registered data or whatsoever is taking place.
The material-tree-renderer example has been updated to demonstrate this new feature.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.4%) to 89.204% when pulling dde82a0 on edgarmueller:topic/add-item-dialog-default into 64fb88f on eclipsesource:master.

Copy link
Member

@eneufeld eneufeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, would like to discuss pros and cons of the suggested solution though

@eneufeld
Copy link
Member

I suggest to merge this and create a new issue in order to discuss how we can improve the way default data can be provided to jsonforms.

@edgarmueller
Copy link
Contributor Author

@eneufeld Sounds good, could you approve the PR then, please?

@edgarmueller edgarmueller merged commit 536d43a into eclipsesource:master Sep 27, 2018
@edgarmueller edgarmueller added this to the 2.0.12 milestone Nov 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants