Fixed: Issue #897 #898
Fixed: Issue #897 #898
Conversation
Fixed: NullPointer in Wild Web Developer causes POM editor to stop functioning after installing specific plugin eclipse-wildwebdeveloper#897
| Path.fromPortableString(uri.toString())); | ||
| // this constructor will ensure parts are URI encoded correctly | ||
| uri = new URI(url.getProtocol(), url.getAuthority(), url.getPath(), null, null); | ||
| if(Objects.nonNull(url)) { |
There was a problem hiding this comment.
As Objects is not imported, it causes a compilation issue. Why not just using url != null here?
| if(Objects.nonNull(url)) { | |
| if( (url != null) { |
There was a problem hiding this comment.
I modified the code in the github editor, because my hard drive on which I fixed the code crashed. I forgot to add the import of Objects. My bad.
Personally I prefer the Objects.nonNull because it's less error prone than != and ==. You make errors with those operators more easily.
|
I just added the missing import. This should work now. sorry for the inconvenience. Tom |
|
OK, then the final requirement would be that you sign the Eclipse Contributor Agreement, see https://accounts.eclipse.org/legal/eca/validation/121987 |
|
I believe I just filled in the ECA. But he cannot determine the ECA signoff status. |
|
I don't know what I'm doing wrong here... |
|
are you using the same email address to sign the ECA than the one that you use to author the commit? |
|
Yes I just checked that the mail address in my current profile is equal to the emailaddress used in the Eclipse account, resubmitted the ECA, still nothing... |
|
AHA, I just found that I also needed to install the ECA checker on the forked repo in question. |
|
Hello @mickaelistria can you explain what happens next? |
|
What happens next is I say thank you one behalf of m2e and Wild Web Developer! |
Fixed: NullPointer in Wild Web Developer causes POM editor to stop functioning after installing specific plugin #897