-
Notifications
You must be signed in to change notification settings - Fork 76
[XML] Formatting preference page #860
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
mickaelistria
merged 1 commit into
eclipse-wildwebdeveloper:master
from
angelozerr:formatting-preference-page
Sep 6, 2022
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
83 changes: 83 additions & 0 deletions
83
...org/eclipse/wildwebdeveloper/xml/internal/ui/preferences/XMLFormattingPreferencePage.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,83 @@ | ||
| /******************************************************************************* | ||
| * Copyright (c) 2022 Red Hat Inc. and others. | ||
| * | ||
| * This program and the accompanying materials are made | ||
| * available under the terms of the Eclipse Public License 2.0 | ||
| * which is available at https://www.eclipse.org/legal/epl-2.0/ | ||
| * | ||
| * SPDX-License-Identifier: EPL-2.0 | ||
| * | ||
| * Contributors: | ||
| * Angelo ZERR (Red Hat Inc.) - initial implementation | ||
| *******************************************************************************/ | ||
| package org.eclipse.wildwebdeveloper.xml.internal.ui.preferences; | ||
|
|
||
| import static org.eclipse.wildwebdeveloper.xml.internal.ui.preferences.XMLPreferenceConstants.XML_PREFERENCES_FORMAT_CLOSING_BRACKET_NEW_LINE; | ||
| import static org.eclipse.wildwebdeveloper.xml.internal.ui.preferences.XMLPreferenceConstants.XML_PREFERENCES_FORMAT_EMPTY_ELEMENTS; | ||
| import static org.eclipse.wildwebdeveloper.xml.internal.ui.preferences.XMLPreferenceConstants.XML_PREFERENCES_FORMAT_JOIN_COMMENTLINES; | ||
| import static org.eclipse.wildwebdeveloper.xml.internal.ui.preferences.XMLPreferenceConstants.XML_PREFERENCES_FORMAT_PRESERVE_ATTRIBUTE_LINE_BREAKS; | ||
| import static org.eclipse.wildwebdeveloper.xml.internal.ui.preferences.XMLPreferenceConstants.XML_PREFERENCES_FORMAT_SPACE_BEFORE_EMPTY_CLOSE_TAG; | ||
| import static org.eclipse.wildwebdeveloper.xml.internal.ui.preferences.XMLPreferenceConstants.XML_PREFERENCES_FORMAT_SPLIT_ATTRIBUTES; | ||
| import static org.eclipse.wildwebdeveloper.xml.internal.ui.preferences.XMLPreferenceConstants.XML_PREFERENCES_FORMAT_SPLIT_ATTRIBUTES_INDENT_SIZE; | ||
| import static org.eclipse.wildwebdeveloper.xml.internal.ui.preferences.XMLPreferenceConstants.XML_PREFERENCES_FORMAT_XSI_SCHEMA_LOCATION_SPLIT; | ||
|
|
||
| import org.eclipse.jface.action.Action; | ||
| import org.eclipse.jface.dialogs.IDialogConstants; | ||
| import org.eclipse.jface.preference.BooleanFieldEditor; | ||
| import org.eclipse.jface.preference.ComboFieldEditor; | ||
| import org.eclipse.jface.preference.FieldEditorPreferencePage; | ||
| import org.eclipse.jface.preference.IntegerFieldEditor; | ||
| import org.eclipse.ui.IWorkbench; | ||
| import org.eclipse.ui.IWorkbenchPreferencePage; | ||
| import org.eclipse.wildwebdeveloper.xml.internal.Activator; | ||
| import org.eclipse.wildwebdeveloper.xml.internal.ui.Messages; | ||
|
|
||
| /** | ||
| * XML formatting preference page. | ||
| * | ||
| */ | ||
| public class XMLFormattingPreferencePage extends FieldEditorPreferencePage implements IWorkbenchPreferencePage { | ||
|
|
||
| public XMLFormattingPreferencePage() { | ||
| super(GRID); | ||
| } | ||
|
|
||
| @Override | ||
| public void createFieldEditors() { | ||
| // Settings for tag elements | ||
| addField(new ComboFieldEditor(XML_PREFERENCES_FORMAT_EMPTY_ELEMENTS.preferenceId, | ||
| Messages.XMLFormattingPreferencePage_format_emptyElements, | ||
| new String[][] { { Action.removeMnemonics(IDialogConstants.IGNORE_LABEL), "ignore" }, | ||
angelozerr marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| { Messages.XMLFormattingPreferencePage_format_emptyElements_collapse, "collapse" }, | ||
| { Messages.XMLFormattingPreferencePage_format_emptyElements_expand, "expand" } }, | ||
| getFieldEditorParent())); | ||
| addField(new BooleanFieldEditor(XML_PREFERENCES_FORMAT_SPACE_BEFORE_EMPTY_CLOSE_TAG.preferenceId, | ||
| Messages.XMLFormattingPreferencePage_format_spaceBeforeEmptyCloseTag, getFieldEditorParent())); | ||
|
|
||
| // Settings for attributes | ||
| addField(new BooleanFieldEditor(XML_PREFERENCES_FORMAT_SPLIT_ATTRIBUTES.preferenceId, | ||
| Messages.XMLFormattingPreferencePage_format_splitAttributes, getFieldEditorParent())); | ||
| addField(new IntegerFieldEditor(XML_PREFERENCES_FORMAT_SPLIT_ATTRIBUTES_INDENT_SIZE.preferenceId, | ||
| Messages.XMLFormattingPreferencePage_format_splitAttributesIndentSize, getFieldEditorParent())); | ||
| addField(new BooleanFieldEditor(XML_PREFERENCES_FORMAT_CLOSING_BRACKET_NEW_LINE.preferenceId, | ||
| Messages.XMLFormattingPreferencePage_format_closingBracketNewLine, getFieldEditorParent())); | ||
| addField(new BooleanFieldEditor(XML_PREFERENCES_FORMAT_PRESERVE_ATTRIBUTE_LINE_BREAKS.preferenceId, | ||
| Messages.XMLFormattingPreferencePage_format_preserveAttributeLineBreaks, getFieldEditorParent())); | ||
| addField(new ComboFieldEditor(XML_PREFERENCES_FORMAT_XSI_SCHEMA_LOCATION_SPLIT.preferenceId, | ||
| Messages.XMLFormattingPreferencePage_format_xsiSchemaLocationSplit, | ||
angelozerr marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| new String[][] { | ||
| { Messages.XMLFormattingPreferencePage_format_xsiSchemaLocationSplit_onElement, "onElement" }, | ||
| { Messages.XMLFormattingPreferencePage_format_xsiSchemaLocationSplit_onPair, "onPair" }, | ||
| { Messages.XMLFormattingPreferencePage_format_xsiSchemaLocationSplit_none, "none" } }, | ||
| getFieldEditorParent())); | ||
|
|
||
| // Settings for comments | ||
| addField(new BooleanFieldEditor(XML_PREFERENCES_FORMAT_JOIN_COMMENTLINES.preferenceId, | ||
| Messages.XMLFormattingPreferencePage_format_joinCommentLines, getFieldEditorParent())); | ||
| } | ||
|
|
||
| @Override | ||
| public void init(IWorkbench workbench) { | ||
| setPreferenceStore(Activator.getDefault().getPreferenceStore()); | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Split is probably not the right term. I suggest
Place attributes on separate linesThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like to keep this label since we use it too in vscode-xml and WTP uses too this label: