Skip to content

Update Vscode extensions #816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 25, 2022
Merged

Update Vscode extensions #816

merged 1 commit into from
May 25, 2022

Conversation

vrubezhny
Copy link
Contributor

@vrubezhny vrubezhny commented Apr 21, 2022 •
edited
Loading

vscode 1.63.2 --> 1.66.2

yaml-language-server 1.3.0 --> 1.7.0

Signed-off-by: Victor Rubezhny [email protected]

@vrubezhny
Copy link
Contributor Author

IP Team Review request is created for typescript/4.6.3:

For the other modules clearly defined reports:
Vetted license information was found for all content. No further investigation is required.

@akurtakov
Copy link
Contributor

Why using the old ipzilla? Shouldn't same requestbe made in the iplab ?

@vrubezhny
Copy link
Contributor Author

IP Team Review request is created for vscode/1.66.2:

https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/2399

@vrubezhny vrubezhny force-pushed the update-vscode-2022-04 branch from d92b244 to bcee453 Compare April 29, 2022 14:46
@vrubezhny
Copy link
Contributor Author

vrubezhny commented Apr 29, 2022 •
edited
Loading

IP Team Review request is created for typescript/4.6.4:

https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/2440

For the other modules clearly defined reports:
Vetted license information was found for all content. No further investigation is required.

@vrubezhny vrubezhny force-pushed the update-vscode-2022-04 branch from bcee453 to c02f1ef Compare April 29, 2022 16:34
@vrubezhny
Copy link
Contributor Author

Why using the old ipzilla? Shouldn't same requestbe made in the iplab ?

Opening a CQ here still may have sense as it's opened only for three LS extensions (provided in source code attached to the CQ) while the iplab request can be made only for the whole vscode source (at least currently don't know how to make it for only the json/html/css extensions). Normally it takes more time to resolve a CQ than an iplab request, but in this certain case the license check is complete for the CQ (https://dev.eclipse.org/ipzilla/show_bug.cgi?id=24057) while the iplab request is still under investigation (https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/2399)

@vrubezhny vrubezhny force-pushed the update-vscode-2022-04 branch 7 times, most recently from ab0da5b to b68bd82 Compare May 10, 2022 15:16
@vrubezhny vrubezhny force-pushed the update-vscode-2022-04 branch 13 times, most recently from fe724a8 to 49dfd47 Compare May 13, 2022 17:53
mickaelistria
mickaelistria reviewed May 13, 2022
View reviewed changes
@vrubezhny vrubezhny force-pushed the update-vscode-2022-04 branch from 49dfd47 to cd37d16 Compare May 13, 2022 20:03
@mickaelistria
Copy link
Contributor

The example is taken from stackoverflow: https://stackoverflow.com/questions/10149539/conditional-configuration-in-maven-pom-xml

Please read the answers as well as the questions. This construct doesn't exist in Maven. Conditional configuration is achieved with profiles.

Adding the following ... construction made the local and WindowsPR builds to work normally.

Because all that block is fully ignored, and the Authorization header is never added, and the download quotas are not exceeded yet for today to cause a download failure.

So, I suppose it really works.

No, not at all :P

@mickaelistria
Copy link
Contributor

Can you please update this PR to include only LS update and create a separate PR for memory+docker settings?

@mickaelistria
Copy link
Contributor

@vrubezhny Can you please rebase? We may be able to merge those now.

@vrubezhny
Update Vscode extensions
0380e7c 
vscode                        1.63.2 --> 1.66.2

yaml-language-server          1.3.0  --> 1.7.0

Signed-off-by: Victor Rubezhny <[email protected]>
@vrubezhny vrubezhny force-pushed the update-vscode-2022-04 branch from cd37d16 to 0380e7c Compare May 24, 2022 15:23
@vrubezhny vrubezhny merged commit 94d9b86 into eclipse-wildwebdeveloper:master May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mickaelistria mickaelistria mickaelistria left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vrubezhny @akurtakov @mickaelistria