Skip to content

Update commons-compress to 1.26.2 #1574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

merks
Copy link
Contributor

@merks merks commented May 25, 2024

No description provided.

@merks
Copy link
Contributor Author

merks commented May 25, 2024

@akurtakov

Unfortunately WWD was bitten by the certificate problem:

image

eclipse-simrel/simrel.build@e4905d9

So I took the liberty to update the target platform.

@merks
Copy link
Contributor Author

merks commented May 25, 2024

The tests fail like this:

java.lang.NoClassDefFoundError: org/apache/commons/lang3/SystemProperties
	at org.apache.commons.compress.archivers.tar.TarArchiveEntry.normalizeFileName(TarArchiveEntry.java:231)
	at org.apache.commons.compress.archivers.tar.TarArchiveEntry.setName(TarArchiveEntry.java:1871)
	at org.apache.commons.compress.archivers.tar.TarArchiveInputStream.getNextTarEntry(TarArchiveInputStream.java:452)
	at org.apache.commons.compress.archivers.tar.TarArchiveInputStream.getNextEntry(TarArchiveInputStream.java:389)
	at org.apache.commons.compress.archivers.tar.TarArchiveInputStream.getNextEntry(TarArchiveInputStream.java:49)
	at org.eclipse.wildwebdeveloper.embedder.node.CompressUtils.extractArchive(CompressUtils.java:71)
...
Caused by: java.lang.ClassNotFoundException: org.apache.commons.lang3.SystemProperties cannot be found by org.apache.commons.commons-compress_1.26.2
	at org.eclipse.osgi.internal.loader.BundleLoader.generateException(BundleLoader.java:562)
	at org.eclipse.osgi.internal.loader.BundleLoader.findClass0(BundleLoader.java:557)
	at org.eclipse.osgi.internal.loader.BundleLoader.findClass(BundleLoader.java:434)
	at org.eclipse.osgi.internal.loader.ModuleClassLoader.loadClass(ModuleClassLoader.java:174)
	at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:526)
	... 103 more

The class does exist:

image

The bundle org.apache.commons.commons-compress declares an optional dependency:

resolution:=optional,org.apache.commons.lang3;

The same was the case for 1.26.1.

But it doesn't appear so optional does it...

@merks merks force-pushed the pr-commons-compress-1.26.2 branch 3 times, most recently from 577a62c to 54bfc82 Compare May 25, 2024 10:18
- Add org.apache.commons:commons-lang3:3.14.0 because apparently
commons-compress's optional requirement on package
org.apache.commons.lang3 is not really so optional.
- Increment version of org.eclipse.wildwebdeveloper.embedder.node.
- Increment versions including features.
@merks merks force-pushed the pr-commons-compress-1.26.2 branch from 54bfc82 to d4d63ad Compare May 25, 2024 10:36
@merks
Copy link
Contributor Author

merks commented May 25, 2024

@akurtakov

Woo hoo, finally the build and tests worked. 🥳

@akurtakov
Copy link
Contributor

/request-license-review

Copy link

/request-license-review

✔️ All licenses already successfully vetted.

Workflow run (with attached summary files):
https://github.com/eclipse-wildwebdeveloper/wildwebdeveloper/actions/runs/9234955097

@akurtakov
Copy link
Contributor

The npm update is not caused by this update thus I'm merging it.

@akurtakov akurtakov merged commit f3a2f7f into eclipse-wildwebdeveloper:master May 25, 2024
@merks
Copy link
Contributor Author

merks commented May 25, 2024

I was just thinking that we probably should increment the versions of these three bundles too:

image

So that the new release has new artifacts for these. Right?

@merks
Copy link
Contributor Author

merks commented May 25, 2024

Yes, I tested the snapshot build and it has these failures problems:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants