Skip to content

Switch css/less/scss to tm4e grammar/language config #1552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 9, 2024

Conversation

akurtakov
Copy link
Contributor

Simplifies wildwebdeveloper development as the project will get the updates from tm4e without the need for CQs and etc.

Simplifies wildwebdeveloper development as the project will get the
updates from tm4e without the need for CQs and etc.
@akurtakov akurtakov self-assigned this May 9, 2024
@akurtakov
Copy link
Contributor Author

@mickaelistria @vrubezhny I would appreciate your review if you have time.

@akurtakov
Copy link
Contributor Author

Added the xsl switch as second commit as without it tests fail. There is some incompatibility which is visible even with master before this PR if one tries to run org.eclipse.wildwebdeveloper.tests.TestXML.testXSLFile with TM4e language pack installed the test fails with:

java.lang.ClassCastException: class org.eclipse.ui.internal.ErrorEditorPart cannot be cast to class org.eclipse.ui.texteditor.ITextEditor (org.eclipse.ui.internal.ErrorEditorPart is in unnamed module of loader org.eclipse.osgi.internal.loader.EquinoxClassLoader @64c3ca20; org.eclipse.ui.texteditor.ITextEditor is in unnamed module of loader org.eclipse.osgi.internal.loader.EquinoxClassLoader @637aaf98)
	at org.eclipse.wildwebdeveloper.tests.TestXML.testXSLFile(TestXML.java:98)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)
	at org.junit.platform.commons.util.ReflectionUtils.invokeMethod(ReflectionUtils.java:727)
	at org.junit.jupiter.engine.execution.MethodInvocation.proceed(MethodInvocation.java:60)
	at org.junit.jupiter.engine.execution.InvocationInterceptorChain$ValidatingInvocation.proceed(InvocationInterceptorChain.java:131)
	at org.junit.jupiter.engine.extension.TimeoutExtension.intercept(TimeoutExtension.java:156)

just like on jenkins (https://ci.eclipse.org/wildwebdeveloper/job/Wildwebdeveloper/job/PR-1552/1/testReport/junit/org.eclipse.wildwebdeveloper.tests/TestXML/testXSLFile/) after the language pack makes it in the dependencies via the first commit of this PR.

Copy link
Contributor

@vrubezhny vrubezhny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks!

@akurtakov akurtakov merged commit 0b6994b into eclipse-wildwebdeveloper:master May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants