Implement gRPC-Web protocol - #89
Merged
Merged
Conversation
tsegismont
marked this pull request as ready for review
February 22, 2024 17:30
vietj
reviewed
Mar 1, 2024
Member
Author
|
@vietj I've removed the milestone and label, they are already set on the corresponding issue |
vietj
reviewed
Mar 7, 2024
Member
Author
|
@vietj PTAL |
tsegismont
force-pushed
the
grpc-web
branch
2 times, most recently
from
March 11, 2024 11:41
a6764db to
7b87dd5
Compare
These tests have been built by inspection of a TCP traffic capture between a browser and the Envoy proxy, configured as recommended by the gRPC-Web project. More tests will be added in follow-up commits Signed-off-by: Thomas Segismont <tsegismont@gmail.com>
Signed-off-by: Thomas Segismont <tsegismont@gmail.com>
Including about CORS setup in Vert.x Web. Signed-off-by: Thomas Segismont <tsegismont@gmail.com>
https://github.com/grpc/grpc-web/blob/a639b4cf2611de2b68883571787083b73cf61f5e/doc/interop-test-descriptions.md Create gRPC-Web prereqs image from a main branch checkout: the prereqs image on Docker Hub might not always be up-to-date (confirmed by gRPC-Web maintainer). Signed-off-by: Thomas Segismont <tsegismont@gmail.com>
Member
Author
|
@vietj I've squashed commits to ease the next review |
vietj
requested changes
Mar 28, 2024
Member
Author
|
@vietj PTAL |
Signed-off-by: Thomas Segismont <tsegismont@gmail.com>
kureuil
reviewed
Mar 29, 2024
The browser does not expose HTTP protocol details so, even if the client and server communicate over HTTP/2, standard gRPC cannot be used and gRPC-Web is mandatory. Signed-off-by: Thomas Segismont <tsegismont@gmail.com>
vietj
reviewed
Apr 5, 2024
vietj
left a comment
vietj
left a comment
Member
There was a problem hiding this comment.
A few minor things and we are good to go
Signed-off-by: Thomas Segismont <tsegismont@gmail.com>
Member
Author
|
@vietj PTAL |
vietj
approved these changes
Apr 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #55
Each commit can be reviewed individually.