Skip to content

Conversation

DocMoebiuz
Copy link
Contributor

@DocMoebiuz DocMoebiuz commented Oct 18, 2022

Desription

pre-commit requires virtualenv, and with recent ubuntu versions 22.x there was a change that makes virtualenv copy the python executable into ./local/bin instead of ./bin
This breaks pre-commit.

Changes

  • downgrade of python setuptools package
  • install two additional packages via apt-get that were missing in base image to build pre-commit wheels

fixes #45

Notes

I created a follow up as improvement for the base image: eclipse-velocitas/devcontainer-base-images#2

Checklist

VehicleApp

  • Vehicle App can be started with dapr run and is connecting to vehicle data broker
  • Vehicle App can process MQTT messages and call the seat service
  • Vehicle App can be deployed to local K3D and is running (blocked by current proxy issue)
  • n/a Created/updated tests, if necessary. Code Coverage percentage on new code shall be >= 70%.
  • n/a Extended the documentation in Velocitas repo
  • n/a Extended the documentation in README.md

DevContainer

  • Devcontainer can be opened successfully
  • Devcontainer can be opened successfully behind a corporate proxy
  • Devcontainer can be re-built successfully

Release flow

  • n/a Release workflow is passing

@DocMoebiuz DocMoebiuz requested review from emsameen and mml5bg October 18, 2022 14:31
@github-actions
Copy link

github-actions bot commented Oct 18, 2022

Unit Test Results

1 tests  ±0   1 ✔️ ±0   1s ⏱️ ±0s
1 suites ±0   0 💤 ±0 
1 files   ±0   0 ±0 

Results for commit 4ece1ee. ± Comparison against base commit d21b16a.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Oct 18, 2022

Trivy Scan Results (sampleapp)

0 tests  ±0   0 ✔️ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
1 files   ±0   0 ±0 

Results for commit 4ece1ee. ± Comparison against base commit d21b16a.

♻️ This comment has been updated with latest results.

Copy link
Member

@emsameen emsameen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DocMoebiuz DocMoebiuz merged commit 381ef3b into main Oct 19, 2022
@DocMoebiuz DocMoebiuz deleted the 45-precommit-hook-fix branch October 19, 2022 10:11
eclipsewebmaster pushed a commit that referenced this pull request Oct 19, 2022
* PreCommit Hooks can be executed without errors
* added python3-dev package
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pre-commit hooks fail in devcontainer
2 participants