Skip to content

Conversation

@JonasHelming
Copy link
Contributor

@JonasHelming JonasHelming commented Dec 21, 2025

What it does

Implement visualization of preference tags in Theia's settings UI, similar to VS Code's behavior. Previously, preferences with tags defined in their schema (e.g., tags: ['experimental']) were not displayed in the UI, making it difficult for users to identify special preference categories.

How to test

Can also be tested in #16784

  1. Set a tag on a preference (e.g. tags: ['experimental'])
  2. Navigate to File > Preferences > Settings (or use the command palette: "Preferences: Open Settings (UI)") and look at the preference
  3. Verify that:
    • Tags appear as styled badges next to the preference name
    • Multiple tags are displayed with proper spacing
    • Tags follow the theme colors and remain readable in both light and dark themes
    • The tags don't interfere with other UI elements (prefix, suffix, modified indicators)

Breaking changes

  • This PR introduces breaking changes and requires careful review. If yes, the breaking changes section in the changelog has been updated.

Attribution

Review checklist

Reminder for reviewers

@github-project-automation github-project-automation bot moved this to Waiting on reviewers in PR Backlog Dec 21, 2025
@ndoschek ndoschek self-requested a review December 22, 2025 15:00
Copy link
Member

@ndoschek ndoschek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @JonasHelming, this works and looks great and is a nice improvement for the settings UI! 🎉
I added two comments inline, would be great if you could have a look when you have some time.

Besides that, I noticed our settings UI does not support searching for tags, although the PreferenceSchema descriptions says so, however this should not block this PR and we can look at this in a follow up as well, from my POV.

font-weight: bold;
display: flex;
align-items: center;
gap: 8px;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the px values I would prefer to reuse css variables as well wherever possible, e.g. for example we did this also in this recent PR: https://github.com/eclipse-theia/theia/pull/16749/changes#diff-0ecd014bbc1720277b7d8e99100329ae021f624d91392c0d256c33942de8ec32

@github-project-automation github-project-automation bot moved this from Waiting on reviewers to Waiting on author in PR Backlog Dec 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Waiting on author

Development

Successfully merging this pull request may close these issues.

3 participants