Skip to content

Conversation

@CamilleLetavernier
Copy link
Contributor

fixes #16560

What it does

  • add a preference AI Features > Chat > Persisted Session Limit with values:
    • -1: unlimited persisted sessions
    • 0: no persisted sessions
    • n>0: n persisted sessions
  • update the persisted sessions mechanism to take the preference into account and support the new 0 and -1 cases

How to test

  • test all 3 values (-1, 0, and n>0) and make sure the behavior matches the expectations above
    • note: persisted sessions are the sessions saved to disk. They are different from in-memory sessions. Refresh your browser tab when you want to check what is currently persisted, as in-memory sessions have no limit
    • note: sessions are trimmed only when a new session is available. Changing the setting doesn't have an immediate effect; you need to start a new conversation in order to update the current persisted sessions

Follow-ups

Breaking changes

  • This PR introduces breaking changes and requires careful review. If yes, the breaking changes section in the changelog has been updated.

Attribution

Review checklist

Reminder for reviewers

@github-project-automation github-project-automation bot moved this to Waiting on reviewers in PR Backlog Dec 19, 2025
Copy link
Member

@ndoschek ndoschek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this fix @CamilleLetavernier, works great for me! 👍
Just a small question inline if you have a minute, TIA!

Copy link
Member

@ndoschek ndoschek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM 👍

@github-project-automation github-project-automation bot moved this from Waiting on reviewers to Needs merge in PR Backlog Dec 19, 2025
@CamilleLetavernier CamilleLetavernier merged commit 7f7ef6a into master Dec 19, 2025
10 checks passed
@CamilleLetavernier CamilleLetavernier deleted the issues/16560 branch December 19, 2025 14:28
@github-project-automation github-project-automation bot moved this from Needs merge to Done in PR Backlog Dec 19, 2025
@github-actions github-actions bot added this to the 1.68.0 milestone Dec 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

AI Persistence: Preference for Persisted Session Limit

3 participants