feat: preserve LSP Diagnostic.data in markers #16766
Open
+13
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msujew
reviewed
Dec 18, 2025
packages/plugin/src/theia.d.ts
Outdated
Comment on lines
10346
to
10349
| /** | ||
| * A data entry field that is preserved between diagnostics and code actions. | ||
| */ | ||
| data?: LSPAny; |
Member
There was a problem hiding this comment.
Suggestion: The original implementation does not contain this field. Adding it here will result in a mismatch between our interfaces and the one from VSCode, see also our comparison report.
If you want to add it (for typing reasons), please add this to the theia-extra.d.ts file.
| endColumn: number; | ||
| relatedInformation?: RelatedInformation[]; | ||
| tags?: MarkerTag[]; | ||
| data?: LSPAny; |
Member
There was a problem hiding this comment.
Suggestion: Since this value can stem from non-LSP sources, it doesn't really make sense to use LSPAny here. Simply use any.
Contributor
Author
There was a problem hiding this comment.
@msujew Thanks for your Suggestion. I've addressed your comments. Please take another look.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Implemented conversion for the data field in the diagnostic <-> marker lifecycle by updating convertDiagnosticToMarkerData and reviveMarker, enabling ProblemManager markers to carry the data payload. The data field is an opaque, server-defined payload used to attach metadata to a diagnostic and must be preserved by the client. This field is defined on the Diagnostic interface in the vscode-languageserver-protocol package as below:
How to test
Follow-ups
Breaking changes
Attribution
Review checklist
nlsservice (for details, please see the Internationalization/Localization section in the Coding Guidelines)Reminder for reviewers