Fix local plugin readme file resolution #16376
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-project-automation
bot
moved this from Waiting on reviewers
to Needs merge
in PR Backlog
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Fixes an issue of #14699, discovered via #16371.
The
..appended to the URI path simply was incorrect, but it was never noticed, because theelsecase (which requests the readme file from thereadmeUrlproperty) was still able to load the readme file on case-insensitive file system.This change implements the intended behavior which loads the readme file via the
FileService.How to test
This either requires a case-sensitive file system (Linux) or to debug the code of the source directly. Follow the steps from #13595 and rename the readme file from
README.mdin theextensiondirectory of the plugin toreadme.md. The file should still load correctly (using theFileService#readFilemethod now).Review checklist
Reminder for reviewers