Evaluate enablement and toggle state of command only once before to show context menu.

[Hanksha]

What it does

This PR evaluate enablement and toggle state of command only once before to show it. This prevents the enablement to be checked every time the mouse hovers the menu item.

Closes #16208

How to test

• Check enablement of menu items still work correctly.
• Check enablement/toggle state is only checked once via isEnabled/isToggled (add console.log or breakpoint)

Attribution

Contributed on behalf of Lonti.com Pty Ltd.

Review checklist

• As an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

• As a reviewer, I agree to behave in accordance with the review guidelines

[colin-grant-work]

This does indeed avoid subsequent reevaluations of enablement. 👍

[colin-grant-work]

@Hanksha, you've indicated that this commit should be attributed to Lonti.com Pty Ltd. I believe that that is usually reflected in the commit message for the commit and in the changelog, though it seems that the attribution section of the code of conduct has been abbreviated, perhaps unintentionally?

@ndoschek, can you confirm whether the attribution needs to be included in the final commit message, or just the changelog?

[Hanksha]

@colin-grant-work Sorry, I was unaware that I needed to do something else, I just saw the attribution section in the PR template and thought it was enough. It seems it was not a problem on my previous PRs (I see the "contributed on behalf" in the changelog) but let me know if I need to change anything.

[colin-grant-work]

Sorry, I was unaware that I needed to do something else

@Hanksha, no problem. I just want to make sure before I merge the PR that I'm not omitting anything important :-).

[ndoschek]

Thanks @colin-grant-work and @Hanksha!
The attribution section in the PR template was introduced to help with changelog generation (see #14490), appreciate you including it 🙌

If there's no strict requirement to include the attribution in the final commit message from the company's side and having it in the changelog is sufficient for you, that's fine. But to be safe, feel free to add it to the commit message as well.

[Hanksha]

@ndoschek Hi, having it in the changelog is sufficient for me.