Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions NOTICE.md
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,7 @@ Icon configure-inverse.svg (n/a)
* License: MIT
* Project: <https://github.com/Microsoft/vscode>
* Source:
<https://github.com/Microsoft/vscode/blob/master/src/vs/workbench/contrib/tasks/common/media/configure-inverse.svg#L1>
<https://github.com/Microsoft/vscode/blob/1.35.1/src/vs/workbench/contrib/tasks/common/media/configure-inverse.svg#L1>

Icons copied from microsoft/vscode-icons version:
b73945c70f1117c4e65939dd3e10bdd623cb4ef3 (n/a)
Expand Down Expand Up @@ -468,4 +468,4 @@ licensing fees.
We strongly recommend downstream consumers verify the type of FFmpeg support
configured and modify as required. More information on instructions to verify
can be found here
<https://electronjs.org/docs/development/upgrading-chromium#verify-ffmpeg-support>
<https://github.com/electron/electron/blob/c75c3ef61689733cf422c2cc76d51ce05033be33/docs/development/upgrading-chromium.md#verify-ffmpeg-support>
4 changes: 2 additions & 2 deletions doc/coding-guidelines.md
Original file line number Diff line number Diff line change
Expand Up @@ -461,7 +461,7 @@ class MyWidget extends ReactWidget {
* [2.](#frontend-fs-path) Use `FileService.fsPath` to get a path on the frontend from a URI.
<a name="backend-fs-path"></a>
* [3.](#backend-fs-path) Use `FileUri.fsPath` to get a path on the backend from a URI. Never use it on the frontend.
<a name="uri-scheme"></a>
<a name="explicit-uri-scheme"></a>
* [4.](#explicit-uri-scheme) Always define an explicit scheme for a URI.

> Why? A URI without scheme will fall back to `file` scheme for now; in the future it will lead to a runtime error.
Expand All @@ -480,7 +480,7 @@ class MyWidget extends ReactWidget {
<a name="use-icon"></a>
* [9.](#use-icon) Use `LabelProvider.getIcon(uri)` to get a system-wide file icon.
<a name="uri-no-string-manipulation"></a>
* [10.](#uri-no-string-manipulations) Don't use `string` to manipulate URIs and paths. Use `URI` and `Path` capabilities instead, like `join`, `resolve` and `relative`.
* [10.](#uri-no-string-manipulation) Don't use `string` to manipulate URIs and paths. Use `URI` and `Path` capabilities instead, like `join`, `resolve` and `relative`.

> Why? Because object representation can handle corner cases properly, like trailing separators.

Expand Down
4 changes: 2 additions & 2 deletions doc/pull-requests.md
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ If a rule causes distress during discussions itself, it has to be reviewed on [t
<a name="checklist-sign-off"></a>
- [7.](#checklist-sign-off) Commits are signed-off: <https://github.com/eclipse-theia/theia/blob/master/CONTRIBUTING.md#sign-your-work>.
<a name="checklist-meaningful-commits"></a>
- [8.](#checklist-meaningful-commit) Each commit has meaningful title and a body that explains what it does. One can take inspiration from the `What it does` section from the PR.
- [8.](#checklist-meaningful-commits) Each commit has meaningful title and a body that explains what it does. One can take inspiration from the `What it does` section from the PR.
<a name="checklist-commit-history"></a>
- [9.](#checklist-commit-history) Commit history is rebased on master and contains only meaningful commits and changes (less are usually better).
- For example, use `git pull -r` or `git fetch && git rebase` to pick up changes from the master.
Expand Down Expand Up @@ -128,7 +128,7 @@ provided that the original author accepted the [ECA](https://github.com/eclipse-
- [1.](#landing-pr) A PR can be landed when:
- CI build has succeeded.
- The author has accepted the [Eclipse Contributor Agreement](https://github.com/eclipse-theia/theia/blob/master/CONTRIBUTING.md#eclipse-contributor-agreement).
- All checks from [the review checklist](#pull-request-review-checklist) are approved by at least one reviewer.
- All checks from [the review checklist](#review-checklist) are approved by at least one reviewer.
- There are no unresolved review comments.
<a name="merging-pr"></a>
- [2.](#merging-pr) Pull requests satisfying the criteria above should be merged in a timely fashion to avoid a buildup of approved PR's at release time. Responsibility for merging a PR falls to
Expand Down
2 changes: 1 addition & 1 deletion examples/playwright/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ Theia 🎭 Playwright is a [page object](https://martinfowler.com/bliki/PageObje
The Theia 🎭 Playwright page objects introduce abstraction over Theia's user interfaces, encapsulating the details of the user interface interactions, wait conditions, etc., to help keeping your tests more concise, maintainable, and stable.
Ready for an [example](./docs/GETTING_STARTED.md)?

The actual interaction with the Theia application is implemented with 🎭 Playwright in Typescript. Thus, we can take advantage of [Playwright's benefits](https://playwright.dev/docs/why-playwright/) and run or debug tests headless or headful across all modern browsers.
The actual interaction with the Theia application is implemented with 🎭 Playwright in Typescript. Thus, we can take advantage of [Playwright's benefits](https://playwright.dev/) and run or debug tests headless or headful across all modern browsers.
Check out [Playwright's documentation](https://playwright.dev/docs/intro) for more information.

This page object framework not only covers Theia's generic capabilities, such as handling views, the quick command palette, file explorer etc.
Expand Down
2 changes: 1 addition & 1 deletion packages/bulk-edit/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ The `@theia/bulk-edit` extension contributes a `Refactor Preview` widget to the

## Additional Information

- [API documentation for `@theia/bulk-edit`](https://eclipse-theia.github.io/theia/docs/next/modules/bulk-edit.html)
- [API documentation for `@theia/bulk-edit`](https://eclipse-theia.github.io/theia/docs/next/modules/bulk_edit.html)
- [Theia - GitHub](https://github.com/eclipse-theia/theia)
- [Theia - Website](https://theia-ide.org/)

Expand Down
2 changes: 1 addition & 1 deletion packages/monaco/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@

## Description

The `@theia/monaco` extension contributes the integration of the [monaco-editor](https://microsoft.github.io/monaco-editor/index.html).\
The `@theia/monaco` extension contributes the integration of the [monaco-editor](https://microsoft.github.io/monaco-editor/).\
This includes:

- full-feature code editor
Expand Down
2 changes: 1 addition & 1 deletion packages/vsx-registry/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ and its `OVSXRouterConfig` configuration.

## Additional Information

- [API documentation for `@theia/vsx-registry`](https://eclipse-theia.github.io/theia/docs/next/modules/vsx-registry.html)
- [API documentation for `@theia/vsx-registry`](https://eclipse-theia.github.io/theia/docs/next/modules/vsx_registry.html)
- [Theia - GitHub](https://github.com/eclipse-theia/theia)
- [Theia - Website](https://theia-ide.org/)

Expand Down
Loading