Skip to content

Conversation

@buddha314
Copy link

Fixes typo in #15379

What it does

How to test

Follow-ups

Breaking changes

  • This PR introduces breaking changes and requires careful review. If yes, the breaking changes section in the changelog has been updated.

Attribution

Review checklist

Reminder for reviewers

@github-project-automation github-project-automation bot moved this to Waiting on reviewers in PR Backlog Apr 2, 2025
Copy link
Contributor

@JonasHelming JonasHelming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@github-project-automation github-project-automation bot moved this from Waiting on reviewers to Needs merge in PR Backlog Apr 3, 2025
@JonasHelming
Copy link
Contributor

In order to accept contributions, we need you to sign the Eclipse Contributor Agreement (ECA) see https://api.eclipse.org/git/eca/status/gh/eclipse-theia/theia/15380

This is a one time thing. It allows the open source project to keep IP cleanness which is important for commercial adopters. Please review the ECA and let us know if you have any questions. It looks like quite some over head for this simple typo fix, but as mentioned, it is a one time thing and will then be valid for future contributions, too.

@sdirix sdirix mentioned this pull request Apr 3, 2025
2 tasks
@JonasHelming
Copy link
Contributor

@buddha314 Would you be willing to sign the ECA? Otherwise I would close this one and accept https://github.com/eclipse-theia/theia/pull/15383/files , but as you were first, I would prefer to accept this one.

@buddha314
Copy link
Author

Signed! But if you got impatient I understand.

@tsmaeder
Copy link
Member

tsmaeder commented Apr 9, 2025

@buddha314 did you use the same email address you used to sign the commits in the PR? The EF thinks your yahoo email address is not known to them.

@buddha314
Copy link
Author

Ack! No, I've stopped using that email. I suggest you take the other guy's PR just so it's fixed and I'll find another way to sign & contribute. Thank you for the consideration.

@github-project-automation github-project-automation bot moved this from Needs merge to Done in PR Backlog Apr 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants