Fix flaky playwright Theia Main Menu test #13951
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are observing cases where the `.getByRole('button', { name: 'OK' })` resolved to multiple elements (e.g. [here](https://github.com/eclipse-theia/theia/actions/runs/10025491100)).
With this change we limit the selection to the dialog shell and hopefully remove this ambiguity.
Contributed on behalf of STMicroelectronics.
Change-Id: I5ee5b3fc6a683f68da99e219b32784c3f5d4bfb7
planger
force-pushed
the
fix-flaky-playwright-test
branch
from
8896edb to
78e338d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
We are observing cases where the
.getByRole('button', { name: 'OK' })resolved to multiple elements (e.g. here).With this change we limit the selection to the dialog shell and hopefully remove this ambiguity.
Contributed on behalf of STMicroelectronics.
How to test
Check that the Playwright test check in the CI works for this PR.
We will continue to observe the stability after merging this PR.
Follow-ups
None
Review checklist
Reminder for reviewers