Skip to content

Conversation

@tsmaeder
Copy link
Member

@tsmaeder tsmaeder commented Apr 2, 2024

What it does

fixes #13553

Contributed on behalf of STMicroelectronics

How to test

We can't: we'll have to publish a patch version and verify that the patches folder is in included in @theia/cli and that secondary windows then work in Theia IDE.

Review checklist

Reminder for reviewers

Signed-off-by: Thomas Mäder <[email protected]>

Contribute on behalf of STMicroelectronics
@tsmaeder tsmaeder requested a review from jfaltermeier April 2, 2024 13:37
Copy link
Contributor

@jfaltermeier jfaltermeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me, thanks!

@jfaltermeier jfaltermeier merged commit 86bac3e into eclipse-theia:master Apr 3, 2024
jfaltermeier pushed a commit that referenced this pull request Apr 3, 2024
Signed-off-by: Thomas Mäder <[email protected]>

Contribute on behalf of STMicroelectronics
@jfaltermeier jfaltermeier added this to the 1.49.0 milestone Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Secondary Windows empty in 1.48.0-based Applications

2 participants