Skip to content

Conversation

@marcdumais-work
Copy link
Contributor

What it does

In various source files in the code base, code originally from the vscode repository, was re-used. In these instances, there is a copyright header, like below, that refers to the file containing the full license:

/*---------------------------------------------------------------------------------------------
 *  Copyright (c) Microsoft Corporation. All rights reserved.
 *  Licensed under the MIT License. See License.txt in the project root for license information. 
 *--------------------------------------------------------------------------------------------*/

I think we missed adding the full license text, as is mandated by the MIT license.

This commit adds it, renamed for clarity. I think it should still be easy to find, and should be less likely to cause confusion about what license is the main one, in this repository/project.

How to test

N/A

Follow-ups

N/A

Review checklist

Reminder for reviewers

In various source files in the code base, code originally from the vscode
repository, was re-used. In these instances, there is a copyright header,
like below, that refers to the file containing the full license:

/*---------------------------------------------------------------------------------------------
 *  Copyright (c) Microsoft Corporation. All rights reserved.
 *  Licensed under the MIT License. See License.txt in the project root for license information.
 *--------------------------------------------------------------------------------------------*/

I think we missed adding the full license text, as is mandated by the MIT
license.

This commit adds it, renamed for clarity. I think it should still be easy to
find, and should be less likely to cause confusion about what license is the
main one, in this repository/project.

Signed-off-by: Marc Dumais <[email protected]>
@tsmaeder tsmaeder merged commit ce39306 into master Mar 21, 2024
@github-actions github-actions bot added this to the 1.48.0 milestone Mar 21, 2024
@ndoschek ndoschek deleted the vscode-license branch December 5, 2025 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants