plugin-ext-vscode: ignore vsix files in local-plugins dir #13435
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I'm not sure about the approach here: what this PR does is exclude exactly files of type |
Member
|
@xai ping? |
Contributor
Author
|
Yes, you are right, this would be the better approach instead of a very specific exception. I'll adjust the PR. |
Contributor
Author
|
@tsmaeder pong |
This patch fixes an unexpected behavior where Theia would also pick up and deploy .vsix files from the local-plugins directory into the deployedPlugins directory, where they will be treated as user-installed extensions on the next start of theia. Instead, we now only apply the file handlers for .vsix files if they are user extensions. For system plugins, we print a warning message indicating that the plugin has to be unpacked manually. Fixes eclipse-theia#13222 Contributed on behalf of STMicroelectronics Signed-off-by: Olaf Lessenich <[email protected]>
Member
|
While testing, I found #13638, but it happens also in master, so unrelated. |
tsmaeder
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
In the local-plugins directory (i.e., the one passed to theia via the --plugins argument), we expect to find and deploy unpacked extensions.
This patch fixes an unexpected behavior where theia would also pick up and deploy .vsix files from the local-plugins directory into the deployedPlugins directory, where they will be treated as user-installed extensions on the next start of theia.
Instead, we now ignore .vsix files in the local-plugins directory and print a warning to the console.
Fixes #13222
Contributed on behalf of STMicroelectronics
How to test
Follow-ups
Review checklist
Reminder for reviewers