fix: debug configuration provider replaces different provider #13196
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: arekzaluski <[email protected]>
arekzaluski
commented
Dec 20, 2023
Comment on lines
+100
to
+106
| if (this.configurationProviders.has(provider.handle)) { | ||
| const configuration = this.configurationProviders.get(provider.handle); | ||
| if (configuration && configuration.type !== provider.type) { | ||
| console.warn(`Different debug configuration provider with type '${configuration.type}' already registered.`); | ||
| provider.handle = this.configurationProviders.size; | ||
| } | ||
| } |
Contributor
Author
There was a problem hiding this comment.
Different way of solving it is the approach from registerDebugAdapterContribution. Instead of assigning a new handle number we can return Disposable.NULL
1 task
thegecko
approved these changes
Dec 20, 2023
planger
approved these changes
Dec 21, 2023
Contributor
planger
left a comment
planger
left a comment
There was a problem hiding this comment.
Thanks, looks good to me! 👍
Contributor
|
@thegecko If you merge now, it is the todays release :-) |
arekzaluski
added a commit
to ARMmbed/theia
that referenced
this pull request
Dec 22, 2023
…e-theia#13196) Signed-off-by: arekzaluski <[email protected]>
kittaakos
added a commit
to kittaakos/theia
that referenced
this pull request
Mar 7, 2025
When frontend and main VS Code extensions load together, Theia creates two extension host instances to manage different kinds of extensions. Each will register the extensions' contributed debug adapter configuration providers with incremented handles. In cases of handle collisions during the registration of debug configurations, Theia adjusts the handle of incoming providers. However, this adjustment causes issues as the extension host no longer associates the new handle with the original ID. For instance, if the main VSIX contributes two debuggers assigned handles `0` and `1`, and the web VSIX contributes a debugger with a colliding handle `0`, Theia changes the web provider's handle to `2`. Subsequently, when starting a debug session, the main extension attempts to resolve handle `2`, but the frontend extension host only recognizes the initial configuration. This commit addresses the issue by storing the original handle of the debug adapter configuration. During handle ID lookups, it will reference the originally assigned handle instead of the adjusted one, ensuring proper resolution and functionality across both extension host instances. Ref: eclipse-theia#13196
2 tasks
rschnekenbu
pushed a commit
that referenced
this pull request
Mar 13, 2025
When frontend and main VS Code extensions load together, Theia creates two extension host instances to manage different kinds of extensions. Each will register the extensions' contributed debug adapter configuration providers with incremented handles. In cases of handle collisions during the registration of debug configurations, Theia adjusts the handle of incoming providers. However, this adjustment causes issues as the extension host no longer associates the new handle with the original ID. For instance, if the main VSIX contributes two debuggers assigned handles `0` and `1`, and the web VSIX contributes a debugger with a colliding handle `0`, Theia changes the web provider's handle to `2`. Subsequently, when starting a debug session, the main extension attempts to resolve handle `2`, but the frontend extension host only recognizes the initial configuration. This commit addresses the issue by storing the original handle of the debug adapter configuration. During handle ID lookups, it will reference the originally assigned handle instead of the adjusted one, ensuring proper resolution and functionality across both extension host instances. Ref: #13196
laemmleint
pushed a commit
to mvtecsoftware/theia
that referenced
this pull request
Aug 18, 2025
When frontend and main VS Code extensions load together, Theia creates two extension host instances to manage different kinds of extensions. Each will register the extensions' contributed debug adapter configuration providers with incremented handles. In cases of handle collisions during the registration of debug configurations, Theia adjusts the handle of incoming providers. However, this adjustment causes issues as the extension host no longer associates the new handle with the original ID. For instance, if the main VSIX contributes two debuggers assigned handles `0` and `1`, and the web VSIX contributes a debugger with a colliding handle `0`, Theia changes the web provider's handle to `2`. Subsequently, when starting a debug session, the main extension attempts to resolve handle `2`, but the frontend extension host only recognizes the initial configuration. This commit addresses the issue by storing the original handle of the debug adapter configuration. During handle ID lookups, it will reference the originally assigned handle instead of the adjusted one, ensuring proper resolution and functionality across both extension host instances. Ref: eclipse-theia#13196
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
This PR solves the problem when multiple plugins try to register debug configuration provider under the same handle number. Currently the old provider gets replaced. After this change the new number will be assigned.
Similar guard exists already in
registerDebugAdapterContributionHow to test
Follow-ups
Review checklist
Reminder for reviewers