Added support for webview/context menu contributions #13166
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jonah Iden <[email protected]>
msujew
added
vscode
tortmayr
approved these changes
Dec 13, 2023
Contributor
tortmayr
left a comment
tortmayr
left a comment
There was a problem hiding this comment.
Looks good to me an works as expected! Thanks.
There is just one minor unnecessary log in the onContext menu handler but other than that
everything is fine.
Signed-off-by: Jonah Iden <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
closes #12756
implements the webview/context menu contributions from the missing declarative api as seen in #13051
How to test
A small test extension can be found here
this repo also contains a vsix file to download directly.
Go to explorer tab, expand the
Webview Test Viewwebview. This contains two elements opening the context menu on each should return a different command because of their given context through thedata-vscode-contextpropertyFollow-ups
Review checklist
Reminder for reviewers