Add a cli parameter '--userDataArea` to set the Electron 'userData' path #13155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Part of eclipse-theia#13107 Contributed on behalf of STMicroelectronics Signed-off-by: Thomas Mäder <[email protected]>
planger
requested changes
Dec 5, 2023
Contributor
planger
left a comment
planger
left a comment
There was a problem hiding this comment.
Thank you! Code makes sense and works fine. I just have two rather minor comments inline.
| readonly secondInstance: boolean; | ||
| readonly argv: string[]; | ||
| readonly cwd: string; | ||
| readonly secondInstance: boolean; |
Contributor
There was a problem hiding this comment.
I think we should transfer the type doc comments for secondInstance, as it may not be obvious what that means.
| createYargs(argv, process.cwd()) | ||
| .command('$0 [file]', false, | ||
| cmd => cmd | ||
| .option('userDataArea', { |
Contributor
There was a problem hiding this comment.
I suggest using electronUserData to clarify that this is about the Electron user data, and not to confuse with the config location (.theia by default or defined by $THEIA_CONFIG_DIR). WDYT?
Signed-off-by: Thomas Mäder <[email protected]>
Signed-off-by: Thomas Mäder <[email protected]>
planger
approved these changes
Dec 20, 2023
Contributor
planger
left a comment
planger
left a comment
There was a problem hiding this comment.
Thanks, looks good to me! 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows to set a non-default Electron
userDatapath in order to allow two copies of Theia without concurrency issues related to sharedlocalStorageetc.Part of #13107
Contributed on behalf of STMicroelectronics
What it does
Adds the relevant cli parameter.
How to test
Run two instances of Theia with different user data areas and make sure webviews work in both instances and the there are no concurrency-related issues show up in the log.
Review checklist
Reminder for reviewers