notebook api review comments batch 2 #13012
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonah-iden
force-pushed
the
jiden/notebook-api-review-comments-batch-2
branch
2 times, most recently
from
4d363c0 to
c8b9969
Compare
Member
|
@JonasHelming FYI, I don't really have time to test this appropriately today. Also, I believe the actual improvements to end-users are fairly minor, so it's not all too important to get this into the community release. |
jonah-iden
force-pushed
the
jiden/notebook-api-review-comments-batch-2
branch
from
b197d77 to
65f52e6
Compare
msujew
reviewed
Nov 16, 2023
Member
msujew
left a comment
msujew
left a comment
There was a problem hiding this comment.
I didn't look at the behavior yet, but I have a few comments on the code.
packages/notebook/src/browser/contributions/notebook-actions-contribution.ts
Outdated
Show resolved
Hide resolved
packages/notebook/src/browser/service/notebook-editor-widget-service.ts
Outdated
Show resolved
Hide resolved
Signed-off-by: Jonah Iden <[email protected]>
Signed-off-by: Jonah Iden <[email protected]>
better context key reactions of toolbars Signed-off-by: Jonah Iden <[email protected]>
Signed-off-by: Jonah Iden <[email protected]>
Signed-off-by: Jonah Iden <[email protected]>
Signed-off-by: Jonah Iden <[email protected]>
Signed-off-by: Jonah Iden <[email protected]>
Signed-off-by: Jonah Iden <[email protected]>
and type converters Signed-off-by: Jonah Iden <[email protected]>
Signed-off-by: Jonah Iden <[email protected]>
Signed-off-by: Jonah Iden <[email protected]>
Signed-off-by: Jonah Iden <[email protected]>
Signed-off-by: Jonah Iden <[email protected]>
jonah-iden
force-pushed
the
jiden/notebook-api-review-comments-batch-2
branch
from
995c9a4 to
9e4f497
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
This is the second batch of Review comments from #12442
this also starts the bigger review task of reorganizing the types from notebook-common
How to test
here you can find a test notebook.
important things to test:
Follow-ups
Review checklist
Reminder for reviewers