Skip to content

Conversation

@vince-fugnitto
Copy link
Member

@vince-fugnitto vince-fugnitto commented Jun 8, 2023

What it does

Fixes: #12499.

The commit includes the following:

  • upgrades msgpackr to fix an issue with infinite recursion (causes maximum callstack errors)
  • updates our migration guide for downstream adopters on how to fix the issue in the meantime

How to test

Review checklist

Reminder for reviewers

@vince-fugnitto vince-fugnitto added the dependencies issues that plan to update dependencies label Jun 8, 2023
@vince-fugnitto vince-fugnitto self-assigned this Jun 8, 2023
@vince-fugnitto vince-fugnitto force-pushed the vf/msgpackr-upgrade branch 3 times, most recently from 30a096a to b15f561 Compare June 22, 2023 14:59
The commit upgrades `msgpackr` to a version which fixes the infinite
recursion error caused by a problematic DTO calling `toJSON` which
references itself.

Signed-off-by: vince-fugnitto <[email protected]>
@vince-fugnitto
Copy link
Member Author

I need to continue to investigate the issue with the upgrade of msgpackr where the references-view exposed a bug in which we do not send the proper DTO, failing the references-view.

@vince-fugnitto vince-fugnitto mentioned this pull request Jul 11, 2023
1 task
@vince-fugnitto vince-fugnitto marked this pull request as draft July 21, 2023 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies issues that plan to update dependencies

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Using msgpackr@^1.9.0 causes maximum call stack exceeded error

2 participants