Added factory for TheiaDockPanel.
#11154
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Akos Kitta <[email protected]>
paul-marechal
approved these changes
May 13, 2022
Member
paul-marechal
left a comment
paul-marechal
left a comment
There was a problem hiding this comment.
Code LGTM and the apps work for me too on Windows.
Contributor
Author
|
Thank you for the review. 🙏 If the change looks good, please merge. I cannot do it. Thanks! |
Member
|
@kittaakos weird, I still see you as a committer on the project's page? |
Contributor
Author
|
Thanks for the help here with everything, @paul-marechal. I think the committer page is outdated, but I will ask the Eclipse webmaster. |
vince-fugnitto
added
the
extensibility
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
The PR adds a factory for the
TheiaDockPanel. It helps IDE customization.How to test
Load the app, and if you see the shell, it works.
I manually checked both the browser and the electron versions; opened the panels on both sides and bottom one.
Review checklist
Reminder for reviewers